search

InternetHealthReport / ihr-website

Vue.js code for IHR website
https://ihr.iijlab.net/ihr/en
GNU General Public License v3.0
65 stars 122 forks source link

Improve the loading UI of Your connection #847

Closed 0xAnon0602 closed 2 months ago

0xAnon0602 commented 2 months ago

Describe the bug When someone loads the main page of the website, the "Your Connection" dialog box glitches during loading.

https://github.com/user-attachments/assets/c3cfa730-58df-4ef5-aa3d-6899b9304341

abansal15 commented 2 months ago

Hello @0xAnon0602 @dpgiakatos could you please assign this issue to me .

0xAnon0602 commented 2 months ago

@abansal15 Assigned

abansal15 commented 2 months ago

Hello @0xAnon0602 i have raised the pr could you please review it https://github.com/InternetHealthReport/ihr-website/pull/848

dpgiakatos commented 2 months ago

Hi, I will take care of the code review. Thank you!

abansal15 commented 2 months ago

Thanks Does I have to do someone else in this pr?

abansal15 commented 2 months ago

@dpgiakatos according to the contribution guideline should i have to make the changes by creating a new branch with that issue number or as you told in the dev branch ? image

dpgiakatos commented 2 months ago

You have to follow the contribution guidelines. I wanted to briefly explain that we are working with the dev branch, and all our changes should be synchronized with it. Please make sure to follow our contribution guidelines. Thank you!

abansal15 commented 2 months ago

@dpgiakatos i have again raised the pr following the guidelines i hope this time i have not make any mistakes