search

InteropIO / FDC3

Open standards for the financial desktop.
https://fdc3.finos.org
Other
2 stars 1 forks source link

Schemas for error responses #72

Closed kriswest closed 1 year ago

kriswest commented 1 year ago

We just realized that the error responses (from Agent -> Bridge) were not defined in the schemas, this adds them, but does water down protections provided by generated types (as it makes the required fields in a correct response and error response fields both optional)

@tpina @mattjamieson @Vivek-NatWest

kriswest commented 1 year ago

SOmething is screwed with this PR, will recreate.

Also thinking about the approach as we either need to generate separate schemas and types for error responses, or live with non-optional fields being optional in typescript types (as it merges the regular and error responses into one type).

Any opinions on which is better/worse?