search

Inumedia / SlackAPI

.NET Implementation of the Slack team communication platform API.
MIT License
452 stars 243 forks source link

add proxy support #133

Closed gcottrell13 closed 6 years ago

gcottrell13 commented 6 years ago

Adds support for using HttpWebRequest proxy.

Inumedia commented 6 years ago

Why does WebProxy need to be wrapped in another Proxy class?

gpailler commented 6 years ago

@Inumedia .Net and .Net core uses different IWebProxy implementations and using an intermediate class can help to abstract the implementation differences.

My only point about the PR is the proxy settings are static so you cannot instantiate different SlackClient with different proxies settings (but it looks a corner case).

I will work a bit on the proxy support to propose a proper PR with .Net/.NetCore support.

gpailler commented 6 years ago

Proxy support added in #156