Closed smcleodau closed 5 years ago
@smcleodau The review from before still sticks, these things need to be changed before this can be merged in
@smcleodau I know I took 3 months to respond to the PR initially, but if I don't hear back or see changes before end of June, I'm going to close this PR
That's fine, go ahead. We've managed to move on and all is good.
On Thu, May 16, 2019 at 5:59 PM Andy notifications@github.com wrote:
@smcleodau https://github.com/smcleodau I know I took 3 months to respond to the PR initially, but if I don't hear back or see changes before end of June, I'm going to close this PR
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Inumedia/SlackAPI/pull/160?email_source=notifications&email_token=AAHMLSKJ23CTHXMTTTTCM6DPVX7P7A5CNFSM4GIMZGKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVTN6JA#issuecomment-493281060, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHMLSIF4OW6VWJPFBDPWPTPVX7P7ANCNFSM4GIMZGKA .
When adding attachment options, you can now include Select Lists, not just buttons. I added an enum to support the type of Select option and attribute converters to make creating Attachment Options easier.