search

Invictusintl / coinbase-commerce-whmcs

A simple WHMCS gateway that uses the new Coinbase Commerce merchant tools https://commerce.coinbase.com/
GNU General Public License v3.0
17 stars 15 forks source link

waiting for pull request #7

Open PowerChaos opened 2 years ago

PowerChaos commented 2 years ago

hi, can you perform the pull request please, so it is back up to date with the latest code ?

Thank you Greetings from PowerChaos

monti20 commented 2 years ago

You should just create new respository with this, i think author forget about this project

strstr1 commented 2 years ago

I wouldn't merge that too. Because of the exaggerated copyright notice. You either support open source and don't add something ridiculous like that, or you keep the code for yourself. It's simple.

PowerChaos commented 2 years ago

I wouldn't merge that too. Because of the exaggerated copyright notice. You either support open source and don't add something ridiculous like that, or you keep the code for yourself. It's simple.

you are free to remove that code if you like, not that i care about it it got added as i add it to all my scripts ( visual basic plugin ) and because i mainly rewrote the script a lot to get it working but i am sure you really care about that and can apply the fixes yourself , make yourself a pull request and wait 3 years to get it added to the repo

anyway

You should just create new respository with this, i think author forget about this project

it is still a fork of this repo , but you are free to follow or adjust my fork off it , as i personal use it i keep it up to date ( at least working )

rosolinol commented 1 year ago

you are free to remove that code if you like, not that i care about it it got added as i add it to all my scripts ( visual basic plugin ) and because i mainly rewrote the script a lot to get it working but i am sure you really care about that and can apply the fixes yourself , make yourself a pull request and wait 3 years to get it added to the repo

changing few things doesn't mean you have to put every single social media and website link on the code aswell thats some high advertising shit

PowerChaos commented 1 year ago

as stated before , its a visual basic plugin so it automatic add it to any single file i edit and i am to lazy to remove it manual and i am also to lazy to disable the plugin when i am also working on my own scripts just for this single script.

maybe it is indeed a bit overkill that it include social links, and they are not even accurate anymore but again its the plugin that adds it for me so they are all the same on all files i write.

also stated above , feel free to edit it yourself and manual apply the fixes i added ,i basic rewrote the script of the 3 files there exist i rewrote them all 3 so it is not just "changing a few things" not that i really care about it anyway, i only released the fix so others could also use it , and i am not forced to release it in first place and if i liked i could fully rewrite it to my own script, that's where api documentation is for, but i still released it so you can use it...

so write your own if you do not want to use my code, release it as a fork with the copyright removed if it annoys you, rewrite it so it becomes your script ? , do whatever you like to do with it and be happy that there is a working version now that still works as of today.

anyway, thank you for your reply and to show that you care about it :D