search

Ipstenu / varnish-http-purge

Proxy Cache Purge
Apache License 2.0
46 stars 48 forks source link

Same name for adminbar and dashboard button #9

Closed jnachtigall closed 9 years ago

jnachtigall commented 9 years ago

I was puzzled if both buttons really do the same because they are named differently. I thought the adminbar button might only Purge the currently visible page (because it's visible next to "Edit page").

Since both buttons do the same (as I learnt from the code) they should also be name the same way.

Ipstenu commented 9 years ago

The actual intent is to get rid of the dashboard button and stick with the toolbar :) I wanted to keep the Toolbar shorter since the real-estate there is significantly limited.

Would it make more sense to move the button to the far right? The only reason it says "Purge Varnish" and not "Purge Cache" is because people got confused in beta.

jnachtigall commented 9 years ago

The dashboard button says "Purge Varnish Cache", "Purge Cache" is indeed a bit confusing ;)

Moving it to the right would set it a bit off, might be a good idea - but w3tc also is just left-aligned. Not too many quirks is maybe good.

Anyway, since both buttons do the same they should be name same way, I think.

jnachtigall commented 9 years ago

I just noticed this and thought to quickly fix it, but it's really not this important to me.

Ipstenu commented 9 years ago

I went the other way. It's going to be "Purge Cache" all around.