search

IreneKnapp / direct-sqlite

MIT License
35 stars 54 forks source link

add withDatabase, withStatement #104

Closed ocramz closed 8 months ago

ocramz commented 9 months ago

a couple handy brackets

ocramz commented 8 months ago

Hi, do I understand correctly my contribution was rejected because you didn't like the commit message? You do realize it's possible to rewrite those with a squash merge?

On Tue, 23 Jan 2024 at 03:51, Joshua Chia @.***> wrote:

Closed #104 https://github.com/IreneKnapp/direct-sqlite/pull/104.

— Reply to this email directly, view it on GitHub https://github.com/IreneKnapp/direct-sqlite/pull/104#event-11564260078, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNBDKGKRK6A55FXKXFRBDDYP4QRJAVCNFSM6AAAAABAX25OY6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGU3DIMRWGAYDOOA . You are receiving this because you authored the thread.Message ID: @.***>

jchia commented 8 months ago

I didn't really reject the PR. I have pushed the commits myself with updated commit messages as you can see, to quickly close loose ends. I don't know how to change someone's PRs or whether it is even generally possible, as the GitHub UI does not make it obvious.

jchia commented 8 months ago

A merge resulting in no additional commits and no difference to the commit history.