Should we use Text instead of String in the API?

[joeyadams]

This commit replaces all usage of String in Database.SQLite3 with Text. We were already using Text to marshal SQLite3 TEXT data. This commit uses Text instead of String for the following:

• File path passed to open
• Query strings passed to exec and prepare
• Name returned by bindParameterName
• Error details stored in the SQLError

But do we want to do this?

Pro:

• sqlite-simple and persistent-sqlite already use Text, so this would be less conversion for them (and for us, too).

Con:

• It's a little less convenient. Users will have to use OverloadedStrings (or use pack everywhere).
• Users who want more direct conversion can use functions in .Direct instead.
• Fusion might eliminate most or all of the overhead of using String.

An alternative proposal would be to make a Database.SQLite3.Text module. On the other hand, we don't want to put too much code on top of our package, as it's also carrying the sqlite3.c amalgamation.

Thoughts?

[IreneKnapp]

I had already decided to do this, so thank you for doing the work! String is just ludicrously bad, even with fusion.

[joeyadams]

Thanks for merging this.

When can we release the new direct-sqlite? Should it be version 3.0, or 2.1? I'd like to start updating sqlite-simple and persistent-sqlite.

[nurpax]

@IreneKnapp Any thoughts on when the next release will happen? I'd also like to update my library to the latest direct-sqlite.