Upgrade SQLite3 to 3.7.15, don't leak CInt to public API, and add 'interrupt'

IreneKnapp / direct-sqlite

MIT License

35 stars 54 forks source link

Upgrade SQLite3 to 3.7.15, don't leak CInt to public API, and add 'interrupt' #21

Closed joeyadams closed 11 years ago

joeyadams commented 11 years ago

This pull request does the following (in this order):

Upgrade SQLite 3.7.13 to 3.7.15 (changelog)
Minor improvements
87d720f: Change CInt to Int in public API newtypes (fixes #16)
0addc8b: Add bindings for sqlite3_interrupt

The last two commits are the most substantial (well, unless you count work done by the SQLite team :smiley:). The rest are just routine improvements.

nurpax commented 11 years ago

Looks good to me. One nitpick on weird comment indenting (maybe a tabs vs spaces issue?)

nurpax commented 11 years ago

Also: tested Joey's version against sqlite-simple. Builds and works without any changes (so no build breaks due to converting CInt -> Int, at least not in sqlite-simple). I'd vote for releasing this as 2.3.1 rather than 2.4.0.

IreneKnapp commented 11 years ago

I agree - I'll release it as 2.3.1 right now. :)