Build error when using -fsystemlib flag

IreneKnapp / direct-sqlite

MIT License

35 stars 54 forks source link

Build error when using -fsystemlib flag #40

Closed snoyberg closed 10 years ago

snoyberg commented 10 years ago

When I run cabal install direct-sqlite -fsystemlib, I get:

Resolving dependencies...
Downloading direct-sqlite-2.3.9...
Configuring direct-sqlite-2.3.9...
cabal: Package direct-sqlite-2.3.9 can't be built on this system.
Failed to install direct-sqlite-2.3.9
cabal: Error: some packages failed to install:
direct-sqlite-2.3.9 failed during the building phase. The exception was:
ExitFailure 1

sethfowler commented 10 years ago

Probably this is because you need to also specify -f-fulltextsearch, disabling the default support for building with full text search, due to this section of direct-sqlite.cabal:

  if flag(systemlib) {
    cpp-options: -Ddirect_sqlite_systemlib
    extra-libraries: sqlite3
    if flag(fulltextsearch) {
      buildable: False
    }
  } else {

I will integrate a change that should fix this into pull request #41, since that pull request adds another similar flag and this issue makes me realize I need to do something about this to be consistent.

nurpax commented 10 years ago

@sethfowler do you think this could be closed now?

sethfowler commented 10 years ago

I think so, but we should double-check just to be sure. I was kinda hoping @snoyberg would verify that #41 also fixed this issue.

snoyberg commented 10 years ago

I can confirm that -fsystemlib now works with 2.3.12.

sethfowler commented 10 years ago

Fantastic, thanks for verifying the fix! Looks like the issue can be closed.