Closed joeyadams closed 12 years ago
Great change.
This all looks quite solid! I know the feeling of a patch going into the void, so I'm going to do my best to review it rapidly for you, but it is quite a lot to read through. I kinda wish it had been submitted as separate requests for each incremental patch (or even each logical group of them), just as something to keep in mind for the future.
This pull request changes a lot internally, but should not cause any external breakage. It's mostly improvements to internal typing. However, the last commit is a hack imported from persistent-sqlite so direct-sqlite can be used with GHCi.
Here are all the user-facing changes I'm aware of:
Prelude.error
instead of a non-exhaustive pattern match error.