search

IreneKnapp / direct-sqlite

MIT License
35 stars 54 forks source link

Remove 'extra-libraries: pthread' for all OSes #71

Closed kmicklas closed 6 years ago

kmicklas commented 6 years ago

It's not needed with glibc and prevents building with some newer libc's such as bionic for Android.

nurpax commented 6 years ago

@kmicklas It seems like other Haskell sqlite bindings use -lpthread. And sqlite's docs seem to say it should be added. But it's probably not required if the build doesn't break without it.

Do you have any source for this flag being unnecessary on Linux & Mac? I'll merge if it indeed is unnecessary.

kmicklas commented 6 years ago

Yeah on further investigation it looks like technically it is supposed to be there. cc @Ericson2314 who might know more about the history here.

I added back the dependency except with Android excluded in addition to Windows.

nurpax commented 6 years ago

Please squash to single commit with git rebase -i and force push? I'll merge then.

Ericson2314 commented 6 years ago

@nurpax for background. POSIX states programs using pthreads should use -lpthread (perhaps even must use), but with all major libcs today either don't support that in violation of the spec, or don't care one way of the other.

kmicklas commented 6 years ago

Squashed!