Closed smartin015 closed 2 years ago
This is a great idea and one we've considered adding before, and the PR is well implemented 👏
It's just the stl downloads is one of the more buggy parts of the app, it should get better with some backend changing I'm trying to do but I'm on the fence at to whether this should be added or not now.
While we're talking about it, @franknoirot if we were to add it. Where on the page do you think it should be? do you think it's current placement mixed in with the metadata is okay?
Hey thanks so much for this @smartin015, great work!
The point that @Irev-Dev mentioned above is my only concern. Is there any way you could do just a couple design-based tweaks to this? Here's what I've mocked up in Figma (link to the frame is here):
flex: wrap
and using flex-grow
on the "built with" content so that if for some reason they get squeezed on smaller screens the download button can wrap to the next line.IdeHeader
component, including the button background and icon.How's this?
Yo I love it! I can take review @Irev-Dev, try it out across packages.
Awesome, thanks again @smartin015, and thanks for reviewing @franknoirot.
Curv download is working for me @franknoirot, what browser are you using?
Weird @Irev-Dev, I was using Chrome on MacOS last night when I tried it 🤷, glad it's working though.
:/
Closes #584
Extras:
src/helpers/
so the import is more sensical when using it in a different componentdocument-download
icon from https://heroicons.com/ toSvg.tsx
to make the button look fancyDemo:
Tested by clicking the button and receiving a file. I didn't see any available unit test infra, so please LMK if I'm missing any and I'll add it.