ta-data-bcn
commented
2 years ago Your second project looks good. Be careful to draw conclusions from correlations – underrepresentation may be an indication of repression, but perhaps it's the other way around or there are other, deeper root causes of a lack of women receiving the Nobel Prize. It's an interesting topic!
We made a few comments on your code in case you'd like to go above and beyond, but you're already in a good place 👌
Graphs
- Great use of graphs to explain your points, but I think you can dive deeper into other data sources to help prove your points. Right now you are describing the situation, not the cause.
- Please add a key to any heatmaps or correlation charts.
- Try to vary up your graphs – you really liked bar charts ;)
- You can auto-save figures to your images folder using this line of code:
plt.savefig("images/graph_name.png")
Cleaning Functions
- You have plenty of functions! That's awesome, but remember to add them to a separate file and import.
Files
- It looks like you tried to banish your .ds store, but it's still hiding in your data and code folders 😅 also your cache file
- It's a good idea to separate your plots from your memes.
- Please add a src folder for your function file(s).
https://github.com/casoncalvet/Project_2