Joaquin - Githubissues

Ironhack-data-bcn-oct-2022 / project-III-geospatial-data

0 stars 1 forks source link

Joaquin #2

Open jmedina237 opened 2 years ago

jmedina237 commented 2 years ago

https://github.com/jmedina237/project3_GEO.git

ta-data-bcn commented 2 years ago

Three projects down! Two to go. I have a few comments but it was difficult to review without a readme or folders to look through.

Analysis + Visuals

Unfortunately, your readme was empty so I can't remark on your explanation of your findings, but your notebook visuals are strong!
Great heatmaps, a bar chart, you did extra here. Well done!

Code

Please limit the output of your notebooks so we can see your notebooks in the future, especially if it's the only part of your project that you submit!
There are some repetitive blocks of code that you could have turned into functions here. This is your next step, for sure.

Organization

Folder organization: data (for csvs), output (for images from your notebooks), src (for functions files), and notebooks go in your root folder.
Maybe you forgot to upload the other files? It seems like you have a great project! I'm just missing a few things.