Finally I am issuing my third project! Better late than sorry ;)

[amirg33]

https://github.com/amirg33/3_project-III-geospatial-data

Encapsulation was a Big effort, if there is something not clear I will be there for any questions.

[sh-ih]

🗺️ Nice work! Some comments:

• Repository You have an organized repo with a good folder structure. You could rename your Jupyter exploration folder as notebooks and anyone will know what to expect. You could also keep your 4sq.ipynb notebook in this folder. That way, your src folder will only include .py files. That is the most common use for the src folder.

Another possible improvement could be to have a folder just for maps and use the images folder for all other images.

• README Your README is well organized and informative. It would be nice to explain a little bit more on your key findings section, instead of leaving a general assertion like: “SF and London (...) had distinct advantages and limitations compared to New York”. List just the main two or three of each.

• Code You did a great job with the encapsulation/modularization. I really like that you are already adding docstrings and comments inside your functions. Keep doing it!

• Maps The icons and colors you chose for your marks are informative. I do have a question about the NY map you are showing on your README: what’s the radio of your circle? And why did you choose that? It looks a bit weird that you are only showing marks on a concentrated area that is not identified, but your circle is much larger. At a glance, it looks like there are no other venues inside that circle. I saw that to calculate the radius you are using the distance between the two farthest points divided by 2, but I think that is not what’s being shown here: https://github.com/amirg33/3_project-III-geospatial-data/blob/main/images/map.png Maybe check that out to when you have the time

[amirg33]

Thank you very much Sandra for the quick response. I will improve my code and see if I can find the radius problem. When using 4sqr that was the only information that I got even thought I was giving the encapsulated function the same radius.

Best regards, Amir

Sent from Outlook for iOShttps://aka.ms/o0ukef

---

From: Sandra Hernández @.> Sent: Monday, November 20, 2023 6:36:56 PM To: Ironhack-data-bcn-oct-2023/project-III-geospatial-data @.> Cc: Amir Golafshan @.>; Author @.> Subject: Re: [Ironhack-data-bcn-oct-2023/project-III-geospatial-data] Finally I am issuing my third project! Better late than sorry ;) (Issue #24)

🗺️ Nice work! Some comments:

• Repository You have an organized repo with a good folder structure. You could rename your Jupyter exploration folder as notebooks and anyone will know what to expect. You could also keep your 4sq.ipynb notebook in this folder. That way, your src folder will only include .py files. That is the most common use for the src folder.

Another possible improvement could be to have a folder just for maps and use the images folder for all other images.

• README Your README is well organized and informative. It would be nice to explain a little bit more on your key findings section, instead of leaving a general assertion like: “SF and London (...) had distinct advantages and limitations compared to New York”. List just the main two or three of each.

• Code You did a great job with the encapsulation/modularization. I really like that you are already adding docstrings and comments inside your functions. Keep doing it!

• Maps The icons and colors you chose for your marks are informative. I do have a question about the NY map you are showing on your README: what’s the radio of your circle? And why did you choose that? It looks a bit weird that you are only showing marks on a concentrated area that is not identified, but your circle is much larger. At a glance, it looks like there are no other venues inside that circle. I saw that to calculate the radius you are using the distance between the two farthest points divided by 2, but I think that is not what’s being shown here: https://github.com/amirg33/3_project-III-geospatial-data/blob/main/images/map.png Maybe check that out to when you have the time

— Reply to this email directly, view it on GitHubhttps://github.com/Ironhack-data-bcn-oct-2023/project-III-geospatial-data/issues/24#issuecomment-1819521157, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BCXWFKUB23VLLSRKSTLO42TYFOILRAVCNFSM6AAAAAA7SQIJ26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJZGUZDCMJVG4. You are receiving this because you authored the thread.Message ID: @.***>