search

Irys-xyz / arweave-js-sdk

JS SDK for Irys on Arweave
110 stars 95 forks source link

Migrate to `@aptos-labs/ts-sdk` #120

Closed 0xmaayan closed 7 months ago

0xmaayan commented 7 months ago

resolves https://github.com/Irys-xyz/js-sdk/issues/119

Aptos has a new TS SDK and it is encouraged to migrate over to the new one for a better support and project integrations.

Note: I tested the e2e Irys flow locally using local builds. I couldn't find any tests or documentation regarding contribution steps. Please let me know if anything else is needed to complete the pull request.

Some feedback to share while working on the irys source code:

  1. Could be nice to type the input arguments to be easily used by other projects, for reference https://github.com/Irys-xyz/js-sdk/blob/main/src/node/base.ts#L93
  2. Having the service full url we just uploaded files/folder to as part of the response can be very helpful 
    type UploadResponse = {
....
url:""
}
JesseTheRobot commented 7 months ago

I changed the base branch so I can merge it and perform a couple fixes - I'll update here with the new PR tracking the final merge & release once said fixes are made