search

Islandora-Labs / islandora_solution_pack_oralhistories

Adds all required Fedora objects to allow users to ingest and retrieve Oral Histories (video/audio) files through the Islandora interface
GNU General Public License v3.0
13 stars 23 forks source link

Issue 119 #120

Closed willtp87 closed 6 years ago

willtp87 commented 6 years ago

This pull is meant to address the issues outlined in 119

It removes the variable islandora_oralhistories_media_uploaded_type and makes derivatives rely on the mimetype of the OBJ DS directly.

How should this be tested?

This can be tested by ingesting an OH audio file followed by an OH video. Before the fix re-running derivatives on the OH audio would generate video derivatives. After the fix it will generate audio derivatives. There are update hooks in this pull that remove variables. It should be verified that they run and remove the variables.

Additional Notes:

This change would impact any downstream code relying on the variable being removed.

MarcusBarnes commented 6 years ago

Thanks @willtp87 - I'll test today.

willtp87 commented 6 years ago

@MarcusBarnes Thanks!