search

Islandora-Labs / islandora_solution_pack_oralhistories

Adds all required Fedora objects to allow users to ingest and retrieve Oral Histories (video/audio) files through the Islandora interface
GNU General Public License v3.0
13 stars 23 forks source link

Oral history media + TRANSCRIPT xml upload creates blank CC option #69

Closed kimpham54 closed 7 years ago

kimpham54 commented 7 years ago

Description Whenever a TRANSCRIPT (xml based) is uploaded, a blank option (the TRANSCRIPT datastream) that does not display captions is added to the CC options.

Steps to Reproduce

  1. Add an audio/video file with TRANSCRIPT. Or just add an audio/video file then add a TRANSCRIPT after the original audio/video is ingested
  2. View the oral history, go to CC

Expected Behaviour A single option (taken from MEDIATRACK) for closed captioning gets created

Actual Behaviour Two options for closed captioning gets created, an language option (taken from MEDIATRACK) and an option (taken from TRANSCRIPT) that does not have a name and does not display captions.

MarcusBarnes commented 7 years ago

Addressed in pull-request https://github.com/digitalutsc/islandora_solution_pack_oralhistories/pull/79 (merged with commit https://github.com/digitalutsc/islandora_solution_pack_oralhistories/commit/d1f61a32759c583765463592dfd8c9586ffad615). Thank you @kimpham54 @Natkeeran.