search

IsraelHikingMap / Site

Israel Hiking Map has maps, route planning, and travel information for Israel. This repository holds the files needed for running the Israel Hiking Map site and apps.
https://israelhiking.osm.org.il/
Other
84 stars 33 forks source link

Modernize Angular code by removing decorators #2035

Closed HarelM closed 1 month ago

HarelM commented 1 month ago

@Input => input @Output => output @Viewchild => viewChild @ViewChildren => viewChildren Move inject code from constructor to inject method. Fix relevant tests and code.

CLAassistant commented 1 month ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.33%. Comparing base (80033ab) to head (b6b1b94).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2035 +/- ## ========================================== - Coverage 91.33% 91.33% -0.01% ========================================== Files 93 93 Lines 8106 8103 -3 Branches 985 985 ========================================== - Hits 7404 7401 -3 Misses 477 477 Partials 225 225 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.