IsraelHikingMap / Site

Israel Hiking Map has maps, route planning, and travel information for Israel. This repository holds the files needed for running the Israel Hiking Map site and apps.
https://israelhiking.osm.org.il/
Other
84 stars 33 forks source link

Allow a period in names of images uploaded to Wikimedia #2040

Closed zstadler closed 1 month ago

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.33%. Comparing base (2fe5d22) to head (1e81ccc).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2040 +/- ## ======================================= Coverage 91.33% 91.33% ======================================= Files 93 93 Lines 8103 8103 Branches 985 985 ======================================= Hits 7401 7401 Misses 477 477 Partials 225 225 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HarelM commented 1 month ago

I think the regexp for invalid characters needs to be replaced in order to solve this... In any case, a test needs to be added to make sure this is working as expected...

zstadler commented 1 month ago

I think the regexp for invalid characters needs to be replaced in order to solve this...

a period is a valid character. For example: https://commons.wikimedia.org/wiki/File:0.10_Exhibition.jpg

zstadler commented 1 month ago

In any case, a test needs to be added to make sure this is working as expected...

Could you please take care of that

HarelM commented 1 month ago

WikiClientLibrary doesn't seem to have the relevant interfaces to be able to mock it properly. I'll look into extracting the logic to a helper class that can be unit tested, hopefully...

HarelM commented 1 month ago

Replaced by: