IsraelHikingMap / Site

Israel Hiking Map has maps, route planning, and travel information for Israel. This repository holds the files needed for running the Israel Hiking Map site and apps.
https://israelhiking.osm.org.il/
Other
84 stars 33 forks source link

Trace title doesn't match the planned route name when adding a trace to the map #2043

Closed zstadler closed 1 month ago

zstadler commented 1 month ago

What happened?

I have renamed one of my traces and then added it to the map. The name of the route was the original name of the trace.

What steps will reproduce the bug?

  1. Profile -> My Traces
  2. Select a trace
  3. Edit
  4. Rename it (you may add extra text that can be erased later)
  5. Approve
  6. Click the "+" button
  7. Open "Routes, Maps, and Overlays"
  8. Check the name shown in the Routes section

What I expect to happen

The name shown in the routes list should be the new name

Platform

OS Name and Version

Win 11 pro

Browser Name and Version

No response

Additional information

Renamed trace to add: image

Name of added route: image

HarelM commented 1 month ago

I don't think it has anything to do with rename... The name of the recording isn't really it's name, because you can't use special characters in OSM (hebrew characters for example), so the description is being used as the name, which caused some bugs in the past, and apparently this big as well I believe. Unless I'm missing something here - even if you don't rename you get this "unwanted" behavior, right?

zstadler commented 1 month ago

You are right. The traces list shows the only the trace description while the route list shows only the trace name. When looking at IHM-created traces, both have the same date and time, which allows you to correlate them.

When the user edits the trace description, the ability to correlate the trace and route is lost

image

zstadler commented 1 month ago

One option to improve the situation, is to copy the description from the OSM trace to the route description.

For example, the OSM trace has this description

image

Yet, the route created from it does not have a description

image

If I copy (by hand) the description from the OSM trace to the route, it would show during mouse hover or long press image

It's not an optimal solution, yet it provides some way of associating the route with the trace it represents.

HarelM commented 1 month ago

In all places related to traces we use the trace description as its title, this case shouldn't be different. It's a question if this should be done in server side or client side, and what should happen for traces that were not recorded using our app, but I think that's a minor issue to take into consideration. Right now I think a good solution would be the following using client side only code: image