search

IsraelHikingMap / Site

Israel Hiking Map has maps, route planning, and travel information for Israel. This repository holds the files needed for running the Israel Hiking Map site and apps.
https://israelhiking.osm.org.il/
Other
84 stars 33 forks source link

Refactor location component #2047

Closed HarelM closed 4 weeks ago

HarelM commented 4 weeks ago

Fixes #2046 by moving the logic out of the component to a service that binds both device orientation and geo location. This was on my mind for a long time and the bug below surfaced the need to do it. This also adds tests to these parts of the code that were previously untested.

CLAassistant commented 4 weeks ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov-commenter commented 4 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.83%. Comparing base (82dd0dd) to head (1b733ae).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2047 +/- ## ========================================== - Coverage 91.34% 90.83% -0.51% ========================================== Files 93 95 +2 Lines 8111 8238 +127 Branches 986 1015 +29 ========================================== + Hits 7409 7483 +74 - Misses 477 530 +53 Partials 225 225 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.