search

IsraelHikingMap / Site

Israel Hiking Map has maps, route planning, and travel information for Israel. This repository holds the files needed for running the Israel Hiking Map site and apps.
https://israelhiking.osm.org.il/
Other
84 stars 33 forks source link

Make button sizes the same as top-right, fix overlap of green outline, and increase green outline width by 50% #2051

Closed MAvaisAshraf closed 3 weeks ago

MAvaisAshraf commented 3 weeks ago
  1. Make button sizes the same as top-right button. Keep sizes of all icons as-they-are(Increased height)
  2. Avoid overlap of green overlays of "active" buttons (added margins)
  3. Increase the width of the green overlay line by 50% (i.e 1px)

screen-shot

codecov-commenter commented 3 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.75%. Comparing base (ec5112d) to head (983bade).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2051 +/- ## ======================================= Coverage 90.75% 90.75% ======================================= Files 95 95 Lines 8242 8242 Branches 1016 1016 ======================================= Hits 7480 7480 Misses 537 537 Partials 225 225 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

HarelM commented 3 weeks ago

Can you please share a screenshot of the search after clicking the "+" button to see how the buttons look inside?

MAvaisAshraf commented 3 weeks ago

Screenshot of buttons inside "+" image

HarelM commented 3 weeks ago

Thanks for all the work! I'll take it from here.