Isrothy / neominimap.nvim

Yet another minimap plugin for Neovim
MIT License
159 stars 3 forks source link

Todo Comments #156

Closed spencer-thompson closed 3 weeks ago

spencer-thompson commented 1 month ago

Is your feature request related to a problem? Please describe. Perhaps some confusion relating to how the mini map finds highlights. I went down a rabbit hole trying to figure out why statuscol.nvim breaks all the handlers. This wasn't too big of a deal to me though.

Describe the solution you'd like Looking at the other handler files it seems like it won't be too difficult to implement, but once I get some time I will probably open a pull request.

To put it more clearly, I would like to add a handler for todo-comments.nvim

The highlight group names are as follows:

I think there might be one or two more, see the link above if needed.

Describe alternatives you've considered I haven't really thought of anything else. I do like this plugin though, and would love to contribute :)

Additional context image

spencer-thompson commented 1 month ago

Disregard what I said about the statuscol.nvim plugin. I figured that part out.

Isrothy commented 1 month ago

Thank you for the suggestion! I’m not sure whether we need to directly integrate todo-comments.nvim or if it could be handled using regular expressions. I’m currently considering exposing a handler API that would allow users to register their own handlers. This way, the internal code wouldn’t need frequent updates for specific integrations. Would love to hear your thoughts on this approach.

spencer-thompson commented 1 month ago

I like that a lot. Another idea, or inspiration is transparent.nvim where you give the plugin a string as a prefix and it handles the background highlights for all highlight groups with that prefix. I am sure this is itself just a regex but could possibly make it more easy to use for anyone that doesn't know regex.

Example: require('transparent').clear_prefix('gitsigns')

If you could pass that (or something like it) into the config that would be pretty slick.

Isrothy commented 1 month ago

I really like your idea! However, since it’s more of a hack, I won’t be implementing it directly into the plugin. Instead, I’ll expose it through the API, and it will be documented in the tips section of the wiki for those who want to use it. Just a heads-up, I’m heading back to school soon, so updates might be a bit slower.

spencer-thompson commented 1 month ago

No worries, good to know. I am excited to see. I'm at school too so I understand haha

Isrothy commented 3 weeks ago

Please checkout v3.6.0 and the wiki