search

ItsDeltin / Overwatch-Script-To-Workshop

Converts scripts to Overwatch workshops.
207 stars 24 forks source link

Incorrect output for default workshop custom settings #495

Open SlenderFox opened 2 weeks ago

SlenderFox commented 2 weeks ago

After creating a workshop custom setting you can then specify the default values in customGameSettings.json, however the values this outputs are wrong.

customGameSettings.json: image Produces this output: image

customGameSettings.json: image produces this output: image

Expected output: image

CactusPuppy commented 2 weeks ago

Could you please provide an example of when the last Expected Output should be expected? I am unfamiliar with any situations where the Overwatch Workshop outputs a setting as an array with one element.

SlenderFox commented 2 weeks ago

Did some more experimenting with this, the expected output is produced specifically with WorkshopSettingCombo, when custom game settings are copied while the values are set to something other than default. The copied settings are correctly decompiled into the settings.json but incorrectly compiled back into the overwatch format. A similar issue also happens with WorkshopSettingInteger and WorkshopSettingReal; the values are incorrectly trailed with a % like #493.