search

ItsDrike / CommandBot

Discord Bot which can handle most administrative tasks for servers.
Other
0 stars 0 forks source link

Apply further suggestions from merged #49 #51

Closed ItsDrike closed 4 years ago

ItsDrike commented 4 years ago

PR #49 introduced silencing, but after it has been merged, further suggestions were made, this applies them

ItsDrike commented 4 years ago

self.muted_channels doesn't seem to be used anywhere, there is no point in having it

ItsDrike commented 4 years ago

https://github.com/ItsDrike/CommandBot/blob/942d4e2722a7cb985670b5ede5996751ec118135/bot/cogs/moderation/silence.py#L126

-             await ctx.send(f"{Emojis.cross_mark} current channel is not silenced")
+            await ctx.send(f"{Emojis.cross_mark} current channel was not silenced")

It would be more sensible to use was instead of is here.

ItsDrike commented 4 years ago

Tests were successful, this is ready.