search

Itszuvalex / Femtocraft-alpha-1

Late-game Minecraft Mod
http://femtocraft.blogspot.com
GNU General Public License v2.0
4 stars 2 forks source link

Fixed power container's chat message double printing #32

Closed helpiminabox closed 10 years ago

Itszuvalex commented 10 years ago

If I were to make the debug print only the server info, I wouldn't gate the remote client like that. Instead, put the isRemote check inside the if condition. That way, if it fails, it still consults the super check, which does some fancy work with player distance and tool requirements, and also causes onSideActivate() calls to the underlying tileEntity. While these are at the moment only important on the server side, it is foreseeable that there could be occasions those checks would still want to be called clientside.

helpiminabox commented 10 years ago

Ah. Originally I did do it that way, but I saw that some of the other blocks were done that way, so I wasn't sure if that's how it was supposed to go. Also didn't know that that was debug info.

Itszuvalex commented 10 years ago

Yeah it just comes down to whether there's functionality in super or not. The ones that don't generally just would have been calling a function that returns true or false, whereas this one actually still does some stuff.