search

J-Lentz / iwgtk

Lightweight wireless networking GUI (front-end for iwd)
GNU General Public License v3.0
223 stars 15 forks source link

Hides Passwords #17

Closed VaguePenguin closed 3 years ago

VaguePenguin commented 3 years ago

This update hides passwords in dialogs. If you let me know where you're getting icons from/which icon you'd like for visibility, I can add a icon button to toggle password visibility. This is targeting issue #8

J-Lentz commented 3 years ago

Thanks for the contribution.

GTK 4 provides a GtkPasswordEntry widget with a built-in visibility toggle, so I think the most straightforward plan for the visibility toggle is to get it for free after porting to GTK 4. I'm planning to port to GTK 4 later this year, perhaps around October/November.

If you are interested in implementing a visibility toggle for use in the meantime, I think the best icons to use would be the ones supplied by GTK 4: https://gitlab.gnome.org/GNOME/gtk/-/blob/master/gtk/icons/scalable/status/eye-not-looking-symbolic.svg https://gitlab.gnome.org/GNOME/gtk/-/blob/master/gtk/icons/scalable/status/eye-open-negative-filled-symbolic.svg