J-Lindvig / Fuelprices_DK

Scraping of 5 types of fuel :fuelpump: from 8 different fuelcompanies in Denmark :denmark:.
GNU General Public License v3.0
20 stars 11 forks source link

Integration is using deprecated `DEVICE_CLASS_*` constants #14

Closed frenck closed 1 year ago

frenck commented 1 year ago

This custom integration uses deprecated DEVICE_CLASS_* constants in its codebase.

The DEVICE_CLASS_* constants have been deprecated and replaced in Home Assistant Core 2021.12 (over a year ago). I would highly suggest updating/migrating this integration to the new enums.

For example, for the device classes supported by the sensor platform, there is now a SensorDeviceClass enum. So if a sensor previously used the DEVICE_CLASS_ENERGY constant, it should now use SensorDeviceClass.ENERGY. Other platforms (like binary_sensor, and number) provide similar enumerations for their supported device classes.

The migration thus only consists of replacing constants with an enumeration member and is, therefore, very low impact and should be fairly straightforward.

If I can help resolve any questions regarding this change or migration, feel free to ask or respond to this issue. I'm happy to help!

Kindest regards,

../Frenck

J-Lindvig commented 1 year ago

Thank you. Found the needed info in the source of SENSOR. New version is launched with the change.

frenck commented 1 year ago

Thanks, @J-Lindvig 👍

Happy New Year 🥂

../Frenck