J3fftw1 / LiteXpansion

GNU General Public License v3.0
1 stars 0 forks source link

Glass cutter #48

Closed NCBPFluffyBear closed 4 years ago

NCBPFluffyBear commented 4 years ago

Short Description

Added glass cutter, an item that instantly breaks glass.

Additions/Changes/Removals

Registered and added GLASS_CUTTER

Related Issues

N?A

Checklist

NCBPFluffyBear commented 4 years ago

https://streamable.com/6p0cgg

WalshyDev commented 4 years ago

We follow Google Code Style by the way so please do follow that. Especially regarding formatting and line-length.

J3fftw1 commented 4 years ago

Make it an electric tool im not sure if i want normal tools in lx

J3fftw1 commented 4 years ago

do you have a vid?

NCBPFluffyBear commented 4 years ago

https://streamable.com/xut2ih actually found a bug while doing this ill update in a bit

NCBPFluffyBear commented 4 years ago

Also do u think i should make it glowy

WalshyDev commented 4 years ago

You can break like 85 glass with one charge there. That's quite a lot.

NCBPFluffyBear commented 4 years ago

Yes you can break 600 glass with 1 charge... breaking 1 stack kinda small

NCBPFluffyBear commented 4 years ago

No need to cancel? Its a ghast tear not a shear

J3fftw1 commented 4 years ago

My bad

NCBPFluffyBear commented 4 years ago

The problem is that right click interaction is slower than left click.. maybe 5x or more

WalshyDev commented 4 years ago

The problem is that right click interaction is slower than left click.. maybe 5x or more

You could hold right click and run along a line of glass, it'd get them all. I don't see why you'd have an issue with that

NCBPFluffyBear commented 4 years ago

Its very slow. Right clicking has a set delay no matter if you hold it or not, left click triggers as soon as you are looking at a new block face. If you want, I can make a video showing the speed difference. I saved the right click version I made a while ago

NCBPFluffyBear commented 4 years ago

Actually, the wrench accepts both left and right click. Ill demonstrate using that. https://streamable.com/gtzgi2

NCBPFluffyBear commented 4 years ago

I could also have i accept both left and right clicks so that players can break glass slowly or quickly, thats part of the reason why that exists for the wrench

J3fftw1 commented 4 years ago

Make sure to check for sf machines that are glass that those doesnt get broken

NCBPFluffyBear commented 4 years ago

Already does

NCBPFluffyBear commented 4 years ago

Tested and recorded it working too