search

JBKahn / flake8-debugger

flake8 debug statement checker
MIT License
41 stars 10 forks source link

Remove deprecated setup_requires #25

Closed zupo closed 3 years ago

zupo commented 4 years ago

pytest-runner is used in a deprecated way: from setup_requires.

Most of the time this is not an issue, but sometimes it is: when installing the package using pip, setup_requires step tries to get pytest-runner. And that's the problem: the way setup_requires tries to get the missing package is not honoring pip configuration, such as different index, certificates, proxies, etc.

Which means the installation of this package can fail in environments where pip needs to be correctly configured to use proxies for Internet access.

Additionally, pytest-runner itself says that it is not recommended anymore:

pytest-runner depends on deprecated features of setuptools and relies on features that break security mechanisms in pip. For example ‘setup_requires’ and ‘tests_require’ bypass pip --require-hashes. See also pypa/setuptools#1684.

JBKahn commented 3 years ago

This should be solved by moving to poetry.

JBKahn commented 3 years ago

Let me know if 4.0.0 still has the same problems.

zupo commented 3 years ago

Yep, fixed in master! Thanks a ton!