noqa after end of multi-line print statement

JBKahn / flake8-print

flake8

MIT License

119 stars 22 forks source link

noqa after end of multi-line print statement #10

Closed jayvdb closed 8 years ago

jayvdb commented 9 years ago

Currently it requires the #noqa on the same line as the print statement

print("foo"  # noqa
      " bar")

JBKahn commented 9 years ago

I'll take a look at this when I have some time, probably this coming weekend, I think I know why it's currently doing that, I'll see if I can tweak the code to work on the last line after the bracket.

jayvdb commented 8 years ago

Related flake8 plugins:

https://github.com/openstack-dev/hacking/blob/master/hacking/checks/python23.py#L81 only handles print statements, and
https://github.com/flowroute/ebb-lint#one-off-scripts has an unusual alternative to noqa and an extreme anti-noqa hack which cant be disabled (https://github.com/flowroute/ebb-lint/issues/7)

They would be worth documenting for people looking for slightly different linting outcomes.

jayvdb commented 8 years ago

I'm hoping to have this implemented in a codebase which will be participating in the Google Code-In, to reduce workload on reviewers. GCI starts December 7. Could this be released before then?

JBKahn commented 8 years ago

Oh right, forgot that I meant to release it. Tomorrow!

On Thu, Nov 19, 2015, 11:40 PM John Vandenberg notifications@github.com wrote:

I'm hoping to have this implemented in a codebase which will be participating in the Google Code-In, to reduce workload on reviewers. GCI starts December 7. Could this be released before then?

— Reply to this email directly or view it on GitHub https://github.com/JBKahn/flake8-print/issues/10#issuecomment-158277391.

JBKahn commented 8 years ago

it's out.

jayvdb commented 8 years ago

much appreciated.