search

JBenda / inkcpp

Inkle Ink C++ Runtime with JSON>Binary Compiler
MIT License
70 stars 13 forks source link

String Comparison Unit Test Failing on Linux #18

Closed brwarner closed 3 years ago

brwarner commented 3 years ago 
1: Scenario: compare concatenated values
1:       Given: string and numbers
1:        When: concatenated string representation match (many fields)
1:        Then: == results true
1: -------------------------------------------------------------------------------
1: /home/runner/work/inkcpp/inkcpp/inkcpp_test/Value.cpp:82
1: ...............................................................................
1: 
1: /home/runner/work/inkcpp/inkcpp/inkcpp_test/Value.cpp:85: FAILED:
1:   REQUIRE( res.get<int32_t>() == 1 )
1: with expansion:
1:   0 == 1

Full Log: https://github.com/brwarner/inkcpp/runs/1881136054?check_suite_focus=true

brwarner commented 3 years ago

Strange that it only fails on Linux and not Win/Mac...

JBenda commented 3 years ago

Interesting, on my Linux is dose't fail ... image

brwarner commented 3 years ago

Maybe try a release build locally? That's what the GitHub action is using.

JBenda commented 3 years ago

Yes, now it fails too localy, Ok than I can start debugging ^^

brwarner commented 3 years ago

Cool. If you merge master before uploading your PR, it should now automatically run the tests on the PR.