search

JBenda / inkcpp

Inkle Ink C++ Runtime with JSON>Binary Compiler
MIT License
70 stars 13 forks source link

Implemented Tags #26

Closed frantufro closed 3 years ago

frantufro commented 3 years ago

Added tag ( '#') parsing and runtime ability to query tags.

JBenda commented 3 years ago

The tags defined from Inkle works different, their tags are only enabled for a line per default. Also, you are able to define tags for knots which than can be queried and also global tags are existed, the different cases are missing in this implementation. Also is clearing the tags on jump the right behavior? Because when we create choices we also jump ? Or?

JBenda commented 3 years ago

Added test cases and a bit documentation ^^, it works the same way as "inklecate" which should be a good thing :)

brwarner commented 3 years ago

Looks like a windows unit test is failing, but passing on linux/mac? Seems like an extra 0 is being inserted into the output for some reason.

JBenda commented 3 years ago

It was a missing NULL terminator when setting a global string from program, no idea why that did not fail earlier.

JBenda commented 3 years ago

The fix is now in #30

JBenda commented 3 years ago

Closed because fork is deleted, continue in #32