Fix Unreal Build and 4.26 Compatibility

JBenda / inkcpp

Inkle Ink C++ Runtime with JSON>Binary Compiler

MIT License

70 stars 13 forks source link

Fix Unreal Build and 4.26 Compatibility #35

Closed brwarner closed 11 months ago

brwarner commented 3 years ago

Unreal build is currently broken due to the latest changes. A lot of the issues are around the stricter compiler and clashes between local names and Unreal defines.

github-actions[bot] commented 3 years ago

Ink Proof Results

These results are obtained by running the Ink-Proof Testing Suite on the compiled binaries in this pull request.

System	Results
Linux x64	130/130 passed
MacOSX	DISABLED
Windows x64	DISABLED

JBenda commented 3 years ago

Looks nice, thanks for the messages and more explicit names ^^ (*PS: I didn't expect to have forgotten so many sign/unsigned problems :sweat_smile: )

brwarner commented 3 years ago

Yeah. Some of it is that Unreal has defines that are clashing with your names, like check and OUT.

JBenda commented 11 months ago

Is outdated in favor of #55