search

JBenda / inkcpp

Inkle Ink C++ Runtime with JSON>Binary Compiler
MIT License
70 stars 13 forks source link

Platform #6

Closed JBenda closed 3 years ago

JBenda commented 3 years ago

For Issue #5 Hey I really like the project, so I thought maybe let it compile for GCC (and Linux) is a nice warm up.

When my coding style doesn't fit your convention I will change it happily. Also, I think there is maybe one or two things you would to discuss.

A minimal example runs, also inkcpp_test runs without complaints (it is green).

brwarner commented 3 years ago

Hey!

This is really helpful @JBenda. Thanks so much. The requirement to sometimes add the typename/template keyword always gets me confused. I wish the MSVC compiler would just match requirements of the C++ standard so I wouldn't have accumulated so many issues. Your fixes are great; I've merged them into the branch. If everything compiles fine on my machine I'll then compile it into master.

If you want to continue to contribute, shoot me an email at brwarner2@gmail.com and maybe I can work out some tasks that need doing. Otherwise my next goal is to get the ink-proof testing system running on this project and then just one by one fixing the broken tests (so far it looks like I'm failing 80% of them lol).