The insitu/potential temperature conversion is currently being performed in UFO (via InsituTemperature), but this requires a separate vertical interpolation that also does this conversion. If we add a recipe to VADER to do the conversion, we can then use the generic vertical interpolator that is in UFO. We can then depreciate, and eventually remove, the InsituTemperature observation operator. The code should be cleaner and more maintainable this way.
We'll also want to sort out the model names, afterward, before this is used by other people (e.g. ROMS)
[x] Add GSW support to VADER
[x] Add the non-linear insitu/potential temperature recipe to VADER
[ ] Add the linear insitu/potential temperature recipe to VADER
[ ] Change the yamls in SOCA / Skylab to use the generic vertical interpolator and VADER recipe.
[ ] Compare the two methods (conversion in VADER vs conversion in UFO) it shouldn't make a big difference, but who knows
Description
The insitu/potential temperature conversion is currently being performed in UFO (via
InsituTemperature
), but this requires a separate vertical interpolation that also does this conversion. If we add a recipe to VADER to do the conversion, we can then use the generic vertical interpolator that is in UFO. We can then depreciate, and eventually remove, theInsituTemperature
observation operator. The code should be cleaner and more maintainable this way.We'll also want to sort out the model names, afterward, before this is used by other people (e.g. ROMS)