JDKMissionControl / jmc

This mirror is deprecated - please start using https://github.com/openjdk/jmc
197 stars 46 forks source link

LongStored and DoubleStored are not accessible from other packages #7

Open ferstl opened 5 years ago

ferstl commented 5 years ago

The classes LongStored and DoubleStored are not accessible outside the package org.openjdk.jmc.common.unit. The reason for this is that these are inner static classes of ScalarQuantity which is has only package-private visibility. Trying to access these classes leads to a compile error:

org.openjdk.jmc.common.unit.ScalarQuantity.LongStored is defined in an inaccessible class or interface

A fix would be to make ScalarQuantity public. I'd like to access the LongStored and DoubleStored classes in order to find out if the underlying value of an attribute is a long or a double with an instanceof check.

thegreystone commented 5 years ago

Hi Stefan!

Any particular reason you want to do this?

ferstl commented 5 years ago

Hi, I am trying to read flight recorder events with the API in Mission Control. When I read an attribute of an event it would be good to know if the underlying value is a Long or a Double. Having access to LongStored and DoubleStored I could do an instanceof check. Or is there another way to find out the type? I saw that Mission Control does also make such instanceof checks, e.g. in LinearKindOfQuantity.