search

JDutil / spree_gift_card

Spree Extension adding Gift Card functionality.
BSD 3-Clause "New" or "Revised" License
29 stars 117 forks source link

Can't checkout with a spree gift card in the cart, nor apply existing gift cards #33

Closed Senjai closed 10 years ago

Senjai commented 10 years ago

Test App: https://github.com/Senjai/giftcards

Vanilla 2.0 spree install. Using rails g spree:install then the generators provided by spree_gift_card

I cannot purchase a gift card as a guest or user and I cannot use a giftcard as a user (only seems to work during a guest checkout)

The errors I get are as follows

During the checkout process after filling in my address etc, it says the fields cannot be processed and to double check for missing fields. This appears to happen in the the checkout_controller's update action the address is still valid as long as I remove the gift card from my cart.

Attempting to use a gift card with a user with the appropriate email address fails at both the cart screen and the payment screen of the process with a flash notice stating the gift code does not exist when it was created in the admin backend.

ccschmitz commented 10 years ago

I'm running into this same error, @Senjai. I'm using a fork of the extension for our app but if I patch this I will share the fix here.

Senjai commented 10 years ago

@ccschmitz Much obliged, it's on my list of things to do as well.

Senjai commented 10 years ago

cc @seantaylor

JDutil commented 10 years ago

Sorry I really haven't had time to look into this yet. I haven't been experiencing issues in my app, but if you do solve this or think you figure out the issue before I have time to look into it further please let me know

JDutil commented 10 years ago

@Senjai are you sure that the order & gift card your attempting to checkout with is actually meeting all of this criteria? https://github.com/jdutil/spree_gift_card/blob/master/app/models/spree/gift_card.rb#L51-L56

Senjai commented 10 years ago

@jdutil I want to say yes, given that it was a vanilla spree install with the giftcard plugin. However I'll have to actually run some tests to make sure that function is failing or passing. I may be able to do this sometime next week.

JDutil commented 10 years ago

I've not been able to reproduce this problem yet, and I am deprecating this extension anyways so will be closing out until further information or a pull request to fix the problem is submitted