Closed djjudas21 closed 1 year ago
Here's the clean pylint on my fork: https://github.com/djjudas21/Piexif/actions/runs/4633293513
And here's the failing pytest on my fork: https://github.com/djjudas21/Piexif/actions/runs/4633293511
Hi @djjudas21 whats the status of this MR? I think its a great and very valuable effort to move to github actions!
Argh sorry @djjudas21 and @HerrMuellerluedenscheid I don't know how I missed this 🙈
Thanks for the all the hard work. It's great work, so I'll merge now and make you a maintainer.
@djjudas21 oh, apparently you already are a maintainer, so you should be able to push freely in future!
Here's a summary of what's included in this PR:
.pylintrc
to get a clean lint pass. Ideally these disabled rules should be revisited in the future and fixed rather than disabled, but there's nothing too serious here. Mostly style rather than functionality.PYPI_API_TOKEN
with your PyPI token to allow it to publish. But I guess don't worry about this until Pytest is running properly.Really keen to get this module back into a state where it can be maintained :slightly_smiling_face: