search

JEG2 / highline

A higher level command-line oriented interface.
Other
1.29k stars 137 forks source link

Add Travis CI support #130

Closed elyscape closed 9 years ago

elyscape commented 9 years ago

Issue #129 surfaced recently as a result of insufficient testing. This PR adds automated testing with Travis CI to help avoid similar issues in the future. Once enabled, Travis integrates with GitHub and will display the build status on PRs. It's very convenient.

Some notes:

  1. Some of the builds currently fail. This is because of bugs in highline or the tests that will need to be fixed.
  2. @JEG2 will need to activate Travis builds for this repository at the Travis CI website. I would recommend doing this before merging this PR.
JEG2 commented 9 years ago

Seems like a great idea to me.

elyscape commented 9 years ago

@JEG2 You can trigger an initial build without pushing any commits to the repo by going to the repository's webhook settings, clicking "Travis CI", and hitting the "Test service" button in the upper right corner of the page that loads.

JEG2 commented 9 years ago

Done.

elyscape commented 9 years ago

@JEG2 For some reason it looks like Travis hasn't picked up on it. You made sure to enable Travis for that repo on your Travis profile page, right?

abinoam commented 9 years ago

Great to have Travis CI support :+1: @elyscape

abinoam commented 9 years ago

CI worked fine on my fork. https://travis-ci.org/abinoam/highline

The IO/console bug is easy to fix (I guess). The other, is a test on YAML, and YAML previous versions are buggy. (See #69 and PR #124).

Should we "conditionally" test this?

JEG2 commented 9 years ago

Travis support should be fixed now.