JGCRI / hector

The Hector Simple Climate Model
http://jgcri.github.io/hector/
GNU General Public License v3.0
107 stars 45 forks source link

switch to the main branch #715

Closed kdorheim closed 6 months ago

kdorheim commented 9 months ago

This is to address #697 to change from the default branch from being master to main. To do this will need to update the github action files and documentation.

github-actions[bot] commented 9 months ago

Differences in Hector outputs

Hello, this is leeyabot!

The current pull request's outputs do not differ from 3.0.0 (9aebf67).

codecov-commenter commented 9 months ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@c452322). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 346aad6 differs from pull request most recent head b6946af. Consider uploading reports for the commit b6946af to get more accurate results

@@          Coverage Diff           @@
##             dev     #715   +/-   ##
======================================
  Coverage       ?   79.72%           
======================================
  Files          ?       61           
  Lines          ?     5978           
  Branches       ?        0           
======================================
  Hits           ?     4766           
  Misses         ?     1212           
  Partials       ?        0           
kdorheim commented 9 months ago

@bpbond and @crvernon this should address the code changes fro #697 , I think. I think the outstanding TODOs would be to change the default branch on github and then the default branch on code cov. Do we do that now? Or wait until this is merged into master and then update? Does it need a new release associated with that change? What do you think?

bpbond commented 9 months ago

@kdorheim I'm not sure of the best sequence here, but I guess I would merge this into master and then update the branch name. Don't see the need for a new release since there's no code change.

kdorheim commented 9 months ago

@kdorheim I'm not sure of the best sequence here, but I guess I would merge this into master and then update the branch name. Don't see the need for a new release since there's no code change.

Yea I am also at a loss here 🤷‍♀️