search

JKISoftware / JKI-State-Machine-Editor

The JKI State Machine Editor is a tool to make it easy for developers to use the JKI State Machine. It makes common tasks extremely easy to perform and exposes the user to more “advanced” (non-obvious) JKI SM features (because they are first-class features of the Helper), as well as JKI SM best practices (since the helper can enforce them: left-justification of strings, avoiding chaining states, etc.).
BSD 3-Clause "New" or "Revised" License
17 stars 10 forks source link

SMO Editor deleted some of my code #75

Closed wireddown closed 6 years ago

wireddown commented 6 years ago

The JKI SMO Editor removes the Typedefs from my SMO when I add a public method.

  1. Create a blank Project
  2. Use the SMO Editor to add a BasicByRefWithEvents SMO
  3. Confirm you can run the TestLauncher VI ✅
  4. Use the SMO Editor to add a public method
  5. Observe an error dialog appears ❌
  6. Observe the Typedefs folder is now empty ❌

Usually, when a tool's operations on user data can fail, they can be rolled back by the tool. It would be helpful if these workflows were made transactional: apply-or-noop.

Add a public method

JKI.SMO.Editor.AddPublicMethod

Error dialog

JKI.SMO.Editor.AddPublicMethod.ErrorDialog

Empty Typedefs folder

LabVIEW.ProjectWindow

Error text

Error 8 occurred at Invoke Node in ProjectItem.JKI SMO.lvclass:New PublicEvents--DataCluster.vi->ProjectItem.JKI SMO.lvclass:Add New Event.vi:690001->ProjectItem.JKI SMO.lvclass:Add ProtectedEvents--DataCluster.vi->JKI SMO Editor.lvclass:AddEvent.vi

Possible reason(s):

LabVIEW: (Hex 0x8) File permission error. You do not have the correct permissions for the file.

Method Name: Save:Instrument

Before / after projects

Software

JKI SMO Editor v2.0.1.4 by JKI
Released On: Wed, 27 Apr 2016 08:59:07 -0700
Author: JKI
Copyright: Copyright (c) 2016, JKI
Compatible LabVIEW Versions: >= 2013.
Compatible OS Versions: ALL.
Repository Name: JKI Package Network

Release Notes:
- Changed Public Method to use Private Events to message Process.
- Event can now be empty (boolean placeholder)
- Event that contains only one control will not wrap into a cluster

This Package depends on these other packages:
jki_lib_state_machine >= 2.0.0
OpenG Array Library >= 4.1.1.14
OpenG Error Library >= 4.2.0.23
OpenG File Library >= 4.0.1.22
OpenG LabVIEW Data Library >= 4.2.0.21
OpenG String Library >= 4.1.0.12
OpenG Variant Configuration File Library >= 4.0.0.5
JKI SMO Templates >= 1.0.0.5
JKI State Machine Objects (SMO) >= 1.0.0.11
wireddown commented 6 years ago

Wrong repository. I moved it here: https://github.com/JKISoftware/JKI-State-Machine-Objects/issues/57