FROM email whitelisting isn't working

[lcdservices]

The FROM email address whitelisting functionality isn't actually working. A review of the code indicates the setting and form to enable that functionality exists, but the email check doesn't actually review the from email addresses to find if there's a match. It only looks at the site domain.

Here's a proposed patch: https://gist.github.com/lcdservices/ce1f90cf18c42f44c0648acc3de5a58d

Actually, that would need to be conditioned on whether the setting is enabled. Let me know if you want me to file a PR.

[JoeMurray]

Thanks, Brian!

Edsel, could you QA patch and merge. Also, could you adjust the README.md to indicate on install that the setting can be adjusted if desired, and how to navigate to that page. Please test on jma.staging.ao.

[Edzelopez]

Hi @lcdservices !

Thanks for noticing this! However, I think this stems from the fact that there is another bug that is preventing the FROM email address whitelisting. Could you please share some details on where the whitelisting wasn't working for you? I fixed one bug on the Send Email task on the contact summary page by using this patch: https://gist.github.com/Edzelopez/57db2ad7ecd8571477fbe8411fd52f5e

[lcdservices]

@Edzelopez It's definitely not working. I did the following:

• enabled the FROM whitelisting option in ODE Settings
• added a FROM email address with a domain different from the site
• went to a contrib page and used that email as the FROM address for receipts

It returned the ODE validation warning instead of accepting it as a valid value.

[Edzelopez]

I see what you mean @lcdservices, I agree with your method of fixing. I will provide a more generalised patch taking your code and wrapping it around the existing setting. Thanks for all your help!

[monishdeb]

Moved to https://lab.civicrm.org/extensions/ode/-/issues/23