JPro-one / JPro

The right place to report about bugs or suggest improvements for JPro.
https://www.jpro.one
9 stars 4 forks source link

Is there is a why to set nodeOrientationProperty of Javafx on Jpro.one web? #112

Closed ctoabidmaqbool closed 3 years ago

ctoabidmaqbool commented 3 years ago

I am trying to set nodeOrientationProperty(), but in generated Jpro.one webpage it's totally not affecting.

Is there any method / trick I can't use to solve the problem?

In languages that's are right-to-left I mostly use this trick but in here this is not working.

FlorianKirmaier commented 3 years ago

Hm, It's new to me, that there is a problem with nodeOrientation. To my knowledge, there shouldn't be a problem - especially because JPro doesn't change anything in the behavior for nodeOrientation.

Can you share a sample program, while illustrates the problem? Then we can check whether there is a difference between JPro-Javafx and desktop-Javafx.

ctoabidmaqbool commented 3 years ago

@FlorianKirmaier I have made a simple test where I have used Urdu Language (Pakistani National Language) & Right to Left Layout to demonistrate the issue> https://github.com/Maqbool-Solutions-SMC-Pvt-Ltd/JPro-Orientation-Test [sample is made using latest HelloJpo project]

FlorianKirmaier commented 3 years ago

thank you for the program! we will take a look into it. it seems that both, the node orientation is ignored, and there are some text rendering issues.

FlorianKirmaier commented 3 years ago

Can you test our latest SNAPSHOT build 2021.2.1-SNAPSHOT? This should fix both the rendering of "Right To Left Text" and properly implements the Node.nodeOrientation property.

ctoabidmaqbool commented 3 years ago

@FlorianKirmaier 2021.2.1-SNAPSHOT this solved the problem, but still little problem are exists. You can see difference clear in my another commercial project.

Using latest jpro version 2021.2.0 the problem was much more, but this time it's little

FlorianKirmaier commented 3 years ago

I notice 2 differences - the text in the center seems different, and at the top bar, the order of the texts seems different. Looks like it's ignoring the nodeOrientation for this specific element. Can you try to create another sample program, which reproduces the problem? Then we should be able to fix it.

ctoabidmaqbool commented 3 years ago

@FlorianKirmaier There is another little problem, of font/text position / arrangement on webapp, mybe I have to mention this in another issue. Let see the different>

Desktop Running in Windows 10 e.g. jpro option visable = true in build.gradle file Screenshot (943)

Webapp running in Chrome under window 10 Screenshot (944)

Over all jpro.one technology is cool & much appreciated, also support team is awesome, love it!

ctoabidmaqbool commented 3 years ago

@FlorianKirmaier I have commented just now at https://github.com/Maqbool-Solutions-SMC-Pvt-Ltd/JPro-Orientation-Test

I think, Right-To-Left for label is still not resolved.

Desktop View (Windows 10) Screenshot (949)

Webview (Chrome) Screenshot (951)

Another issue combo-box is showing two popup boxes image

FlorianKirmaier commented 3 years ago

I think the two popups are happening, because of "visible = true", there was the application window in the background.

Hm, the wrong rendered text is a bit tricky. When copying the wrongly rendered texts somewhere, they often get transformed in a similar way.

ctoabidmaqbool commented 3 years ago

@FlorianKirmaier Noop! I have not copy paste Urdu text from any other source, rather write own by install Urdu keyboard layout e.g. Pak Urdu Installer

The problem with Urdu fonts here is that's jpro-web is not using Right-To-Left for these fonts. Moreover see here, in Windows everything is just work fine 100%.

image

however jpro issue, image

And yeah, Combo-box have not any issue, duplicate is showing due to visible = true for another windows

ctoabidmaqbool commented 3 years ago

@FlorianKirmaier Okey, here is another Urude text Rendereing issue: https://github.com/Maqbool-Solutions-SMC-Pvt-Ltd/JPro-Orientation-Test/commit/c0f39b1bb1dec8fd0de84028b3cae0315d588de4

On web (chrome) Screenshot (955)

Self App (Windos 10) Screenshot (957)

FlorianKirmaier commented 3 years ago

Thank you for the updated Bugreport! I've got a new SNAPSHOT version for you to test. We've investigated a bit more with RTL texts, and it also fixes your latest bug report. Can you retest this version? I've got a good feeling about this version.

You might want to check the build-time from the /status page, it should be the following: "JPro build time" : "2021-11-06T19:24:36.398484+01:00[Europe/Berlin]", (or newer)

Ironically, I get various rendering issues with the original JavaFX version.

Screenshot 2021-11-06 at 19 30 27
ctoabidmaqbool commented 3 years ago

@FlorianKirmaier Thank a lot, your latest 2021.2.1-SNAPSHOT solve all problem related to NodeOrientation & RightToLeft issue for RTL Languages. Much appreciated

ctoabidmaqbool commented 3 years ago

@FlorianKirmaier Hi! I have comment again at https://github.com/Maqbool-Solutions-SMC-Pvt-Ltd/JPro-Orientation-Test/commit/3f6d3535aa8fbaea8eef88bbe1a518e6ac79c96d with another issue e.g. Some fonts not looks great at web pages e.g. padding / margin / spacing problem.

Let see the difference:

At web page (chrome) Screenshot (960)

Desktop (Windows 10) Screenshot (959)

FlorianKirmaier commented 3 years ago

fixed in 2021.2.1 (which was verified by the reporter on a SNAPSHOT build)

I've moved the other issue into a new issue.