Closed noelblaschke closed 6 years ago
Please do not change EOL ;)
@JSteunou Updated
@noelblaschke I can't see any benefit changing the code to your proposal. Can you elaborate the case where this is applicable?
About the benefit of this PR:
:-1:
:+1:
@JSteunou The alternative would be:
client: function(url, options = {}) {
const ws = new WebSocket(url, options.protocols || VERSIONS.supportedProtocols());
return new Client(ws, options);
},
I guess this is less breaking. Just a little for those using protocols
inside the Client object, but I don't think this happens. Good call @JimiC :+1:
@noelblaschke I fixed it through #57
Use default options so it is not longer required to pass protocols with a custom options object.