search

JSteunou / webstomp-client

Stomp client over websocket for browsers
Apache License 2.0
299 stars 59 forks source link

Add handling for race condition with RFC6455 style Node websocket lis… #69

Closed Curtis-Fletcher closed 6 years ago

Curtis-Fletcher commented 6 years ago

Add handling for race condition with RFC6455 style Node websocket libs that open their connection in the constructor resulting in a race condition setting onopen when used with webstomp-client

JSteunou commented 6 years ago

I fixed it differently https://github.com/JSteunou/webstomp-client/commit/c5de9c4ca42b13453b35669fa896b5c3fa5d161f

Thanks for the bugfix though, but I could not merge it because you pushed the dist files. Avoid making PR with other changes than just the fix in the source code. This advice is valid for any project you will contribute to ;)

Curtis-Fletcher commented 6 years ago

No problem, sorry about pushing dist. I have minimal experience contributing to transpiled projects, thanks for correcting me.