I've refactored the codebase as of sprint-2. I've tried to elaborate on my reasoning in each commit that I made. These are all nitpicks, but should give you some experience reviewing pull requests.
Seeing as you said you'd be working on this tomorrow I thought I'd squeeze this change in before then.
Please leave any and all questions or changes you wish were made as in-line review comments. You can leave review comments by clicking the line numbers to add a comment on that line under the 'Files changed' tab.
Challenge:
There is one more change that perhaps should be made - it is something public that should be private because no other classes use it. It should be visible in the diff for this PR. Leave a review comment on it when you find it. Happy hunting!
I've refactored the codebase as of sprint-2. I've tried to elaborate on my reasoning in each commit that I made. These are all nitpicks, but should give you some experience reviewing pull requests.
Seeing as you said you'd be working on this tomorrow I thought I'd squeeze this change in before then.
Please leave any and all questions or changes you wish were made as in-line review comments. You can leave review comments by clicking the line numbers to add a comment on that line under the 'Files changed' tab.
Challenge: There is one more change that perhaps should be made - it is something
publicthat should beprivatebecause no other classes use it. It should be visible in the diff for this PR. Leave a review comment on it when you find it. Happy hunting!