Online Typo Corrections

[JTWWilson]

Is it possible to add a text input box onto the site so that anyone can catch spelling errors or even suggest enhancements?

Also, explore whether it is possible to connect this up to GitHub Issues.

[stanley-godfrey]

It could be done, perhaps with an HTML form feeding into a PHP/JavaScript back-end sending an email in our direction. Regarding GH Issues, they can only be made through GitHub as they are not a Git feature.

[stanley-godfrey]

Just done some research and, if we want to have this, it would need self-hosting

[JTWWilson]

You can use the Github API to interact with GitHub issues.

[stanley-godfrey]

Just been doing some research and it's come to my attention that, to create an issue, you need a GitHub account. Thus, would it be better to create a "bot" account that we can use to create issues?

[JTWWilson]

If you want, go for it. This is as far as I got yesterday, if it helps: https://gist.github.com/fabcooldog/e20280192f7bfe4e8ab19362df413f5c

[stanley-godfrey]

Well so far I've had to set up a web server on my Linux box to even do anything (Also, it needs doing in PHP to use the API I believe)

[JTWWilson]

Why do you need to set up a separate server? I've just used Javascript's XMLHTTPRequest object to get and post data using the API.

[stanley-godfrey]

I beg your pardon, I'm doing it with JS now, should be working soon-ish as I've pretty much a copy-and-paste job now

[JTWWilson]

What are you copying and pasting? Could you make a quick Gist so I can see what you're doing?

[stanley-godfrey]

I'm just adapting your code to use an HTML form

[JTWWilson]

Mine doesn't work

[JTWWilson]

It gets data perfectly but post isn't working. I get an error: The system cannot find the path specified.

[stanley-godfrey]

Well I'll get the form accessing done first and then make a Gist... How do I Gist?

[JTWWilson]

Big Gist button at the top of the page (Leave it secret for now -- if you link to it here I can access it)

[stanley-godfrey]

Ahh yes... Also, that auth code in your Gist... Am I able to use that or will it go :scream:

[JTWWilson]

You can use it perfectly I think. If you're getting an error you could always try generating your own (your profile > developers)

[stanley-godfrey]

Okay. Would it be worth, like I mentioned above, making a dedicated issues user which we could use to make the issues, rather than leaving our accounts to do it?

[JTWWilson]

For now, new issues is probably best. However, in the future, using HTML, you can make a drop-down list that generates either a comment on an issue entitled typos/page suggestion etc. or a new issue.

[stanley-godfrey]

Here

It's not making an issue though

[JTWWilson]

That is because of two things:

1. If you want to submit something to the site you need to use post in your request
2. When you correct (1), you get the following error:

HTTP400 BAD REQUEST - The request could not be processed by the server due to invalid syntax. (XHR)POST - https://api.github.com/repos/fabcooldog/resources/issues

I got this error yesterday and hadn't started looking to resolve it.

[stanley-godfrey]

I corrected the GET to POST and, yes, I'm now getting an HTTP 400. I'm now reading the docs and says that all we should need is the issue title and body.

[stanley-godfrey]

Do I have pull access?

[JTWWilson]

To what? Also, I'm sure you need an authentication key as, without it, GitHub doesn't know who is posting the issue.

[stanley-godfrey]

The repository

[JTWWilson]

No one has pull access, I'm happy to approve any changes you make, though. Also, do remember that you can work in a branch, in which you will have full access

[stanley-godfrey]

I've found the problem... You need pull access to create an issue using the API:

Any user with pull access to a repository can create an issue.

[JTWWilson]

Whose key are you using? If it is either of ours then it is fine -- we can create issues and have pull access; the approvals system just limits pull requests, not issues.

[JTWWilson]

Nevertheless, I can disable the approvals for the sake of testing this. - Done.

[stanley-godfrey]

IT'S FREAKING WORKING!!!!!!!!!

[JTWWilson]

With whose key? Try again after I reconnect the approvals.

[stanley-godfrey]

My key

[JTWWilson]

OK, try now.

[stanley-godfrey]

Look in the issue tracker :laughing:

[JTWWilson]

Fantastic, could you pop it up on that Gist you made so I can try it at Chez Me?

[stanley-godfrey]

What's on the menu at Chez Me tonight? :laughing:

[stanley-godfrey]

Gist

[JTWWilson]

Javascript and Further Maths 🎈

[stanley-godfrey]

So, what now?

[JTWWilson]

We need to look at the implementation: instead of copying this into every page, we should put a (relative) link to the Javascripts folder in the head.

[stanley-godfrey]

Okay. It should be pretty simple to do so. Just chuck a rel link into the head and that should be it. I'll quickly check it though

[stanley-godfrey]

Updated Gist

[JTWWilson]

Furthermore, the input box should have a custom ID that attaches to some CSS that automatically adds the labels to the input boxes to make the site more flexible to update. Finally, we might want to look into the following:

• A spam filter that blocks issues with 25> characters
• A drop-down list that allows any typos or other common categories to be comments instead of whole new issues
• Anything else?

[stanley-godfrey]

What do you mean by the labels?

[JTWWilson]

The First Name: signs and placeholder text for the boxes.

[stanley-godfrey]

Why would they need attaching to the boxes? Next thing I know you'll start adding crates as well

[JTWWilson]

I'm not sure how you would do it. Perhaps through divs. Nevertheless, add your current version on to the footer of the main index page - great work!

[stanley-godfrey]

Pull request #37